HomePhabricator

Add Disabled mode to landing revision ui

Description

Add Disabled mode to landing revision ui

Summary:
Fixes T4066.

add isActionDisabled() to DifferentialLandingStrategy, which also explains why it is so.
Make an appropriate pop-up in the controller.

Also make the whole UI "workflow", and convert createMenuItems() to createMenuItem() (Singular).

Test Plan: Click "Land to..." button in all kinds of revisions.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4066

Differential Revision: https://secure.phabricator.com/D8105

Details

Provenance
aviveyAuthored on
epriestleyCommitted on Jan 30 2014, 5:07 PM
epriestleyPushed on Jan 30 2014, 5:07 PM
Reviewer
epriestley
Differential Revision
D8105: Add Disabled mode to landing revision ui
Parents
rP6b4998bf4beb: Increment copyright year and add 2017 dates to calendar import script
Branches
Unknown
Tags
Unknown
Tasks
T4066: Hide the "Land to Hosted Repository" option unless the diff is accepted

Event Timeline