Page MenuHomePhabricator
Create Task
Maniphest T4066

Hide the "Land to Hosted Repository" option unless the diff is accepted
Closed, ResolvedPublic
Actions

Description

Reasonably trivial, but we might want to hide this option from the user if the diff isn't accepted (by default), with a configuration option to perhaps always show the landing option regardless of status.

Revisions and Commits

rP Phabricator
D8105rPd0e30882a11f Add Disabled mode to landing revision ui

Event Timeline

Unknown Object (User) created this task.Nov 6 2013, 6:02 AM
Unknown Object (User) raised the priority of this task from to Needs Triage.
Unknown Object (User) updated the task description. (Show Details)
Unknown Object (User) added a project: Differential.
Unknown Object (User) added subscribers: Unknown Object (User), epriestley, hach-que.
epriestley added a comment.Nov 6 2013, 1:13 PM

If it will become available on accept, it should be visible -- but disabled -- with a dialog showing a message like "You can not land a revision until it has been accepted." when clicked.

avivey added a subscriber: avivey.Nov 7 2013, 5:00 PM
epriestley triaged this task as Normal priority.Nov 18 2013, 4:56 PM
guywarner2 added a subscriber: guywarner2.Jan 28 2014, 1:11 AM
avivey edited this Maniphest Task.Jan 30 2014, 12:16 AM
avivey edited this Maniphest Task.Jan 30 2014, 5:08 PM
avivey closed this task as Resolved.Jan 30 2014, 5:08 PM

Closed by commit rPd0e30882a11f.

Phabricator · Built by Phacility