Page MenuHomePhabricator

underline rule - tweak it a bit
ClosedPublic

Authored by btrahan on Jan 17 2014, 9:46 PM.
Tags
None
Referenced Files
F15425662: D7999.id18097.diff
Sun, Mar 23, 5:20 AM
F15408957: D7999.id18098.diff
Wed, Mar 19, 2:22 AM
F15407757: D7999.id.diff
Tue, Mar 18, 7:22 PM
F15403039: D7999.id18097.diff
Tue, Mar 18, 1:42 AM
F15401927: D7999.diff
Mon, Mar 17, 7:48 PM
F15400107: D7999.id18098.diff
Mon, Mar 17, 9:45 AM
F15382513: D7999.diff
Fri, Mar 14, 12:47 PM
F15353945: D7999.id18097.diff
Tue, Mar 11, 1:09 AM

Details

Summary

basically what you told me to do in D7995, but I also added a "/" to the 'don't capture' clause. In my chosen test code without this check we would end up underlining "and also", and I figured this special case will probably need to handle multiple files in a row with this formatting.

Of course, this means __/something__ also won't be underlined.

Test Plan

plugged the regex into a handy online tool (http://regex101.com/) and played with it a bunch. re-ran unit tests and they passed

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

The internal / seems maybe a tiny bit odd, but we can see what people hit and tweak as necessary.

Cool. I'm working on my orange belt. :D