Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15408957
D7999.id18098.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D7999.id18098.diff
View Options
Index: src/markup/engine/__tests__/remarkup/underline.txt
===================================================================
--- src/markup/engine/__tests__/remarkup/underline.txt
+++ src/markup/engine/__tests__/remarkup/underline.txt
@@ -2,10 +2,12 @@
__underlined text__
__This is a great idea___ die forever please
__
+/__notunderlined__/ and also /__notunderlined__.c
~~~~~~~~~~
<p>omg__ wtf_____ bbq___ lol__
<u>underlined text</u>
<u>This is a great idea_</u> die forever please
-__</p>
+__
+/__notunderlined__/ and also /__notunderlined__.c</p>
~~~~~~~~~~
-omg__ wtf_____ bbq___ lol__ __underlined text__ __This is a great idea___ die forever please __
+omg__ wtf_____ bbq___ lol__ __underlined text__ __This is a great idea___ die forever please __ /__notunderlined__/ and also /__notunderlined__.c
Index: src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleUnderline.php
===================================================================
--- src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleUnderline.php
+++ src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleUnderline.php
@@ -13,7 +13,7 @@
}
return $this->replaceHTML(
- '@(?<!_)__([^\s_].*?_*)__@s',
+ '@(?<!_|/)__([^\s_/].*?_*)__(?!/|\.\S)@s',
array($this, 'applyCallback'),
$text);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 20, 2:22 AM (2 w, 14 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7564847
Default Alt Text
D7999.id18098.diff (1 KB)
Attached To
Mode
D7999: underline rule - tweak it a bit
Attached
Detach File
Event Timeline
Log In to Comment