Page MenuHomePhabricator

Remarkup - add underline rule
ClosedPublic

Authored by btrahan on Jan 17 2014, 8:54 PM.
Tags
None
Referenced Files
F18840551: D7995.id.diff
Tue, Oct 28, 2:07 AM
F18785691: D7995.id18091.diff
Tue, Oct 14, 9:55 AM
F18765220: D7995.id18093.diff
Tue, Oct 7, 10:17 AM
F18756718: D7995.diff
Sun, Oct 5, 1:02 PM
F18619850: D7995.diff
Sep 15 2025, 3:33 AM
F18557116: D7995.id.diff
Sep 8 2025, 7:51 PM
F18513099: D7995.diff
Sep 5 2025, 9:10 AM
F17985707: D7995.id.diff
Aug 1 2025, 9:07 PM

Details

Summary

...and a test even!

Test Plan

tests passed

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is bold in Markdown and will probably get occasional false postiives on __init__.py and such, but I think it's the most logical syntax.

Maybe it's worth using this negative lookbehind prefix (instead of (?<!_)), to avoid matching /__tests__/ and /__init__.py (i.e., "__" is not valid after "/" or "_"):

(?<!_|/)

...and this suffix, for the same cases:

(?!/|\.\S)

(i.e., "__" is not valid before ".x" or "/").

Will update and send out a new diff once I am sure it works... I readily admit my regex foo is yellow belt at best. =D