Page MenuHomePhabricator

Remarkup - add underline rule
ClosedPublic

Authored by btrahan on Jan 17 2014, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 11:10 PM
Unknown Object (File)
Wed, Apr 17, 2:07 AM
Unknown Object (File)
Tue, Apr 16, 12:12 AM
Unknown Object (File)
Mon, Apr 8, 12:05 AM
Unknown Object (File)
Sun, Apr 7, 6:11 AM
Unknown Object (File)
Jan 31 2024, 6:38 AM
Unknown Object (File)
Jan 24 2024, 12:07 PM
Unknown Object (File)
Jan 21 2024, 4:43 PM

Details

Summary

...and a test even!

Test Plan

tests passed

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is bold in Markdown and will probably get occasional false postiives on __init__.py and such, but I think it's the most logical syntax.

Maybe it's worth using this negative lookbehind prefix (instead of (?<!_)), to avoid matching /__tests__/ and /__init__.py (i.e., "__" is not valid after "/" or "_"):

(?<!_|/)

...and this suffix, for the same cases:

(?!/|\.\S)

(i.e., "__" is not valid before ".x" or "/").

Will update and send out a new diff once I am sure it works... I readily admit my regex foo is yellow belt at best. =D