Page MenuHomePhabricator

Remarkup - add underline rule
ClosedPublic

Authored by btrahan on Jan 17 2014, 8:54 PM.
Tags
None
Referenced Files
F14142687: D7995.diff
Tue, Dec 3, 1:43 PM
Unknown Object (File)
Sat, Nov 23, 3:51 AM
Unknown Object (File)
Sat, Nov 9, 5:17 PM
Unknown Object (File)
Oct 24 2024, 11:22 AM
Unknown Object (File)
Oct 20 2024, 11:01 AM
Unknown Object (File)
Oct 6 2024, 11:26 AM
Unknown Object (File)
Sep 12 2024, 2:09 PM
Unknown Object (File)
Sep 11 2024, 10:45 PM

Details

Summary

...and a test even!

Test Plan

tests passed

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is bold in Markdown and will probably get occasional false postiives on __init__.py and such, but I think it's the most logical syntax.

Maybe it's worth using this negative lookbehind prefix (instead of (?<!_)), to avoid matching /__tests__/ and /__init__.py (i.e., "__" is not valid after "/" or "_"):

(?<!_|/)

...and this suffix, for the same cases:

(?!/|\.\S)

(i.e., "__" is not valid before ".x" or "/").

Will update and send out a new diff once I am sure it works... I readily admit my regex foo is yellow belt at best. =D