Page MenuHomePhabricator

Remarkup - add underline rule
ClosedPublic

Authored by btrahan on Jan 17 2014, 8:54 PM.
Tags
None
Referenced Files
F15559578: D7995.id18091.diff
Tue, Apr 29, 9:29 AM
F15519392: D7995.id18093.diff
Sat, Apr 19, 10:30 PM
F15485893: D7995.id18091.diff
Thu, Apr 10, 3:22 AM
F15477791: D7995.diff
Mon, Apr 7, 5:43 PM
F15416287: D7995.id18093.diff
Mar 20 2025, 10:19 AM
F15407998: D7995.id.diff
Mar 18 2025, 8:44 PM
F15406150: D7995.id18091.diff
Mar 18 2025, 12:10 PM
F15399456: D7995.diff
Mar 17 2025, 4:38 AM

Details

Summary

...and a test even!

Test Plan

tests passed

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is bold in Markdown and will probably get occasional false postiives on __init__.py and such, but I think it's the most logical syntax.

Maybe it's worth using this negative lookbehind prefix (instead of (?<!_)), to avoid matching /__tests__/ and /__init__.py (i.e., "__" is not valid after "/" or "_"):

(?<!_|/)

...and this suffix, for the same cases:

(?!/|\.\S)

(i.e., "__" is not valid before ".x" or "/").

Will update and send out a new diff once I am sure it works... I readily admit my regex foo is yellow belt at best. =D