Page MenuHomePhabricator

underline rule - tweak it a bit
ClosedPublic

Authored by btrahan on Jan 17 2014, 9:46 PM.
Tags
None
Referenced Files
F13439441: D7999.diff
Fri, Jul 12, 2:35 AM
F13431268: D7999.id18098.diff
Wed, Jul 10, 7:41 AM
F13429617: D7999.diff
Wed, Jul 10, 3:59 AM
F13401708: D7999.diff
Thu, Jul 4, 1:56 PM
F13390109: D7999.id18097.diff
Tue, Jul 2, 1:03 AM
F13381288: D7999.diff
Sat, Jun 29, 11:12 PM
F13380854: D7999.id18097.diff
Sat, Jun 29, 6:21 PM
F13380781: D7999.diff
Sat, Jun 29, 5:15 PM

Details

Summary

basically what you told me to do in D7995, but I also added a "/" to the 'don't capture' clause. In my chosen test code without this check we would end up underlining "and also", and I figured this special case will probably need to handle multiple files in a row with this formatting.

Of course, this means __/something__ also won't be underlined.

Test Plan

plugged the regex into a handy online tool (http://regex101.com/) and played with it a bunch. re-ran unit tests and they passed

Diff Detail

Branch
underlinetweak
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/markup/engine/__tests__/remarkup/underline.txt:13TXT3Line Too Long
Unit
Tests Passed

Event Timeline

The internal / seems maybe a tiny bit odd, but we can see what people hit and tweak as necessary.

Cool. I'm working on my orange belt. :D