Page MenuHomePhabricator

underline rule - tweak it a bit
ClosedPublic

Authored by btrahan on Jan 17 2014, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 3:10 PM
Unknown Object (File)
Sun, Sep 15, 10:06 AM
Unknown Object (File)
Mon, Sep 9, 8:36 AM
Unknown Object (File)
Sep 4 2024, 11:55 PM
Unknown Object (File)
Aug 16 2024, 10:27 PM
Unknown Object (File)
Aug 11 2024, 10:06 AM
Unknown Object (File)
Aug 11 2024, 10:04 AM
Unknown Object (File)
Aug 11 2024, 10:03 AM

Details

Summary

basically what you told me to do in D7995, but I also added a "/" to the 'don't capture' clause. In my chosen test code without this check we would end up underlining "and also", and I figured this special case will probably need to handle multiple files in a row with this formatting.

Of course, this means __/something__ also won't be underlined.

Test Plan

plugged the regex into a handy online tool (http://regex101.com/) and played with it a bunch. re-ran unit tests and they passed

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

The internal / seems maybe a tiny bit odd, but we can see what people hit and tweak as necessary.

Cool. I'm working on my orange belt. :D