Page MenuHomePhabricator

Fix an issue where PHP puts the content type in CONTENT_TYPE instead of HTTP_CONTENT_TYPE
ClosedPublic

Authored by epriestley on Nov 11 2013, 7:16 PM.
Tags
None
Referenced Files
F18585911: D7561.id17059.diff
Thu, Sep 11, 4:50 PM
F18581645: D7561.id17057.diff
Thu, Sep 11, 6:33 AM
F18581243: D7561.diff
Thu, Sep 11, 5:24 AM
F18579444: D7561.id17057.diff
Thu, Sep 11, 12:50 AM
F18578280: D7561.id17056.diff
Wed, Sep 10, 9:35 PM
F18577533: D7561.id17064.diff
Wed, Sep 10, 7:23 PM
F18469559: D7561.id.diff
Tue, Sep 2, 4:54 PM
F18468435: D7561.id17060.diff
Tue, Sep 2, 3:16 PM
Subscribers

Details

Summary

Fixes T4084. See that task for discussion.

Test Plan

Did git clone. My setup doesn't precisely reproduce the original issue, but hopefully @enko can confirm this is a fix.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:16 PM
  • Stronger check.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:19 PM
  • My brain is derps.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:28 PM
  • Add a unit test.
src/aphront/AphrontRequest.php
491

available

Awesome, thanks for verifying it.

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 8:17 PM
  • Typo fix.