HomePhabricator

Generalize SSH passthru for repository hosting

Description

Generalize SSH passthru for repository hosting

Summary:
Ref T2230. In Git, we can determine if a command is read-only or read/write from the command itself, but this isn't the case in Mercurial or SVN.

For Mercurial and SVN, we need to proxy the protocol that's coming over the wire, look at each request from the client, and then check if it's a read or a write. To support this, provide a more flexible version of passthruIO.

The way this will work is:

  • The SSH IO channel is wrapped in a ProtocolChannel which can parse the the incoming stream into message objects.
  • The willWriteCallback will look at those messages and determine if they're reads or writes.
    • If they're writes, it will check for write permission.
    • If we're good to go, the message object is converted back into a byte stream and handed to the underlying command.

Test Plan: Executed git clone, git clone --depth 3, git push (against no-write repo, got error), git push (against valid repo).

Reviewers: btrahan

Reviewed By: btrahan

CC: hach-que, asherkin, aran

Maniphest Tasks: T2230

Differential Revision: https://secure.phabricator.com/D7551

Details

Provenance
epriestleyAuthored on Nov 11 2013, 8:12 PM
Reviewer
btrahan
Differential Revision
D7551: Generalize SSH passthru for repository hosting
Parents
rPae5fbe034ef8: Fix an issue where Ponder rename stories tried to render question bodies
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task

Event Timeline