Page MenuHomePhabricator

Fix an issue where PHP puts the content type in CONTENT_TYPE instead of HTTP_CONTENT_TYPE
ClosedPublic

Authored by epriestley on Nov 11 2013, 7:16 PM.
Tags
None
Referenced Files
F22887167: D7561.id17060.diff
Thu, Oct 15, 3:46 PM
F22804759: D7561.id17056.diff
Thu, Oct 8, 11:20 AM
F22795923: D7561.id17059.diff
Wed, Oct 7, 2:08 AM
F22675243: D7561.id17060.diff
Thu, Oct 1, 9:32 PM
F22666169: D7561.id17064.diff
Thu, Oct 1, 2:09 PM
Unknown Object (File)
Thu, Sep 17, 2:11 PM
Unknown Object (File)
Aug 14 2026, 1:13 PM
Unknown Object (File)
Aug 8 2026, 4:05 PM
Subscribers

Details

Summary

Fixes T4084. See that task for discussion.

Test Plan

Did git clone. My setup doesn't precisely reproduce the original issue, but hopefully @enko can confirm this is a fix.

Diff Detail

Branch
arequest
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:16 PM
  • Stronger check.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:19 PM
  • My brain is derps.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:28 PM
  • Add a unit test.
src/aphront/AphrontRequest.php
491

available

Awesome, thanks for verifying it.

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 8:17 PM
  • Typo fix.