Page MenuHomePhabricator

Fix an issue where PHP puts the content type in CONTENT_TYPE instead of HTTP_CONTENT_TYPE
ClosedPublic

Authored by epriestley on Nov 11 2013, 7:16 PM.
Tags
None
Referenced Files
F13190198: D7561.id17060.diff
Sat, May 11, 8:09 AM
F13185132: D7561.diff
Sat, May 11, 2:37 AM
F13183267: D7561.id17059.diff
Fri, May 10, 8:03 AM
Unknown Object (File)
Tue, May 7, 4:57 AM
Unknown Object (File)
Fri, May 3, 5:55 PM
Unknown Object (File)
Fri, May 3, 2:22 AM
Unknown Object (File)
Thu, May 2, 9:55 PM
Unknown Object (File)
Tue, Apr 30, 2:13 PM
Subscribers

Details

Summary

Fixes T4084. See that task for discussion.

Test Plan

Did git clone. My setup doesn't precisely reproduce the original issue, but hopefully @enko can confirm this is a fix.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:16 PM
  • Stronger check.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:19 PM
  • My brain is derps.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:28 PM
  • Add a unit test.
src/aphront/AphrontRequest.php
491

available

Awesome, thanks for verifying it.

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 8:17 PM
  • Typo fix.