Page MenuHomePhabricator

Fix an issue where PHP puts the content type in CONTENT_TYPE instead of HTTP_CONTENT_TYPE
ClosedPublic

Authored by epriestley on Nov 11 2013, 7:16 PM.
Tags
None
Referenced Files
F18469559: D7561.id.diff
Tue, Sep 2, 4:54 PM
F18468435: D7561.id17060.diff
Tue, Sep 2, 3:16 PM
F18466599: D7561.diff
Tue, Sep 2, 10:26 AM
F18466237: D7561.id17064.diff
Tue, Sep 2, 9:10 AM
F18465554: D7561.id17059.diff
Tue, Sep 2, 7:24 AM
F18465544: D7561.diff
Tue, Sep 2, 7:23 AM
F18465216: D7561.id17059.diff
Tue, Sep 2, 6:44 AM
F18465202: D7561.id.diff
Tue, Sep 2, 6:41 AM
Subscribers

Details

Summary

Fixes T4084. See that task for discussion.

Test Plan

Did git clone. My setup doesn't precisely reproduce the original issue, but hopefully @enko can confirm this is a fix.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:16 PM
  • Stronger check.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:19 PM
  • My brain is derps.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:28 PM
  • Add a unit test.
src/aphront/AphrontRequest.php
491

available

Awesome, thanks for verifying it.

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 8:17 PM
  • Typo fix.