Page MenuHomePhabricator

Fix an issue where PHP puts the content type in CONTENT_TYPE instead of HTTP_CONTENT_TYPE
ClosedPublic

Authored by epriestley on Nov 11 2013, 7:16 PM.
Tags
None
Referenced Files
F15466394: D7561.id17065.diff
Thu, Apr 3, 5:04 AM
F15465854: D7561.id17060.diff
Wed, Apr 2, 11:49 PM
F15465349: D7561.id17059.diff
Wed, Apr 2, 5:41 PM
F15465022: D7561.id17064.diff
Wed, Apr 2, 1:48 PM
F15464021: D7561.id17056.diff
Wed, Apr 2, 5:32 AM
F15463959: D7561.id.diff
Wed, Apr 2, 5:02 AM
F15461788: D7561.diff
Tue, Apr 1, 11:17 AM
F15442014: D7561.id17065.diff
Wed, Mar 26, 9:00 PM
Subscribers

Details

Summary

Fixes T4084. See that task for discussion.

Test Plan

Did git clone. My setup doesn't precisely reproduce the original issue, but hopefully @enko can confirm this is a fix.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:16 PM
  • Stronger check.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:19 PM
  • My brain is derps.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:28 PM
  • Add a unit test.
src/aphront/AphrontRequest.php
491

available

Awesome, thanks for verifying it.

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 8:17 PM
  • Typo fix.