Page MenuHomePhabricator
Differential D7561

Fix an issue where PHP puts the content type in CONTENT_TYPE instead of HTTP_CONTENT_TYPE
ClosedPublic
Actions

Authored by epriestley on Nov 11 2013, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 3:03 AM
Unknown Object (File)
Sat, Feb 22, 2:33 AM
Unknown Object (File)
Mon, Feb 17, 4:16 AM
Unknown Object (File)
Fri, Feb 14, 8:39 AM
Unknown Object (File)
Wed, Feb 12, 3:48 PM
Unknown Object (File)
Sun, Feb 9, 10:33 AM
Unknown Object (File)
Sun, Feb 9, 10:33 AM
Unknown Object (File)
Sun, Feb 9, 10:33 AM
View All Files
Subscribers
aran
enko

Details

Reviewers
enko
btrahan
Maniphest Tasks
T4084: git clone fails with HTTP-error 415
Commits
Restricted Diffusion Commit
rPdc7f71615668: Fix an issue where PHP puts the content type in CONTENT_TYPE instead of…
Summary

Fixes T4084. See that task for discussion.

Test Plan

Did git clone. My setup doesn't precisely reproduce the original issue, but hopefully @enko can confirm this is a fix.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:16 PM
  • Stronger check.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:19 PM
  • My brain is derps.
epriestley updated this revision to Unknown Object (????).Nov 11 2013, 7:28 PM
  • Add a unit test.
enko accepted this revision.Nov 11 2013, 8:16 PM

Works like a charm.

btrahan added inline comments.Nov 11 2013, 8:16 PM
src/aphront/AphrontRequest.php
491

available

epriestley added a comment.Nov 11 2013, 8:16 PM

Awesome, thanks for verifying it.

epriestley updated this revision to Unknown Object (????).Nov 11 2013, 8:17 PM
  • Typo fix.
epriestley closed this revision.Nov 11 2013, 8:18 PM

Closed by commit rPdc7f71615668 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
aphront/
36 lines
__tests__/
17 lines

Diff 17065

View Options

src/aphront/AphrontRequest.php

Loading...
View Options

src/aphront/__tests__/AphrontRequestTestCase.php

Loading...
Phabricator · Built by Phacility