Page MenuHomePhabricator

Correct Aphlict websocket URI construction after PHP8 compatibility changes
ClosedPublic

Authored by epriestley on Nov 13 2023, 7:00 PM.
Tags
None
Referenced Files
F12521285: D21875.diff
Fri, Feb 23, 10:20 AM
Unknown Object (File)
Wed, Feb 14, 3:46 AM
Unknown Object (File)
Tue, Feb 13, 8:56 PM
Unknown Object (File)
Mon, Feb 12, 12:16 AM
Unknown Object (File)
Sun, Feb 11, 9:00 PM
Unknown Object (File)
Sun, Feb 4, 2:14 AM
Unknown Object (File)
Sun, Feb 4, 2:14 AM
Unknown Object (File)
Sun, Feb 4, 2:14 AM
Subscribers
None

Details

Summary

See D21862. Ref T13700. D21862 affected notification server URI generation behavior when a notification server client is configured with:

  1. no "path" argument; and
  2. "cluster.instance" not set.

Condition (1) is not true default, and condition (2) is not true in my local environment, so it was easy for this to slip through the cracks. Apply the change suggested in D21862.

Also fix a couple other string-null issues I caught locally.

Test Plan

Generated notification server URIs under various simulated local conditions (no instance, path set) and everything seemed to be working correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable