Page MenuHomePhabricator

Correct Aphlict websocket URI construction after PHP8 compatibility changes
ClosedPublic

Authored by epriestley on Nov 13 2023, 7:00 PM.
Tags
None
Referenced Files
F13529853: D21875.diff
Fri, Jul 26, 11:56 PM
F13528407: D21875.id52183.diff
Fri, Jul 26, 7:29 PM
Unknown Object (File)
Tue, Jul 23, 11:14 PM
Unknown Object (File)
Sun, Jul 21, 6:30 AM
Unknown Object (File)
Wed, Jul 17, 9:47 AM
Unknown Object (File)
Wed, Jul 17, 6:45 AM
Unknown Object (File)
Fri, Jul 12, 5:18 AM
Unknown Object (File)
Wed, Jul 10, 10:37 PM
Subscribers
None

Details

Summary

See D21862. Ref T13700. D21862 affected notification server URI generation behavior when a notification server client is configured with:

  1. no "path" argument; and
  2. "cluster.instance" not set.

Condition (1) is not true default, and condition (2) is not true in my local environment, so it was easy for this to slip through the cracks. Apply the change suggested in D21862.

Also fix a couple other string-null issues I caught locally.

Test Plan

Generated notification server URIs under various simulated local conditions (no instance, path set) and everything seemed to be working correctly.

Diff Detail

Repository
rP Phabricator
Branch
php8x2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25838
Build 35666: arc lint + arc unit