Page MenuHomePhabricator

Add a "product name literal in pht()" linter
ClosedPublic

Authored by epriestley on Apr 25 2022, 4:41 PM.
Tags
None
Referenced Files
F13038654: D21763.id51882.diff
Tue, Apr 16, 2:08 AM
Unknown Object (File)
Sun, Apr 14, 10:01 AM
Unknown Object (File)
Thu, Apr 11, 4:14 AM
Unknown Object (File)
Wed, Apr 10, 12:21 AM
Unknown Object (File)
Thu, Apr 4, 10:05 PM
Unknown Object (File)
Wed, Apr 3, 12:17 PM
Unknown Object (File)
Sat, Mar 30, 10:24 AM
Unknown Object (File)
Thu, Mar 28, 8:26 PM
Subscribers
None

Details

Summary

Ref T13658. One challenge in forking Phabricator is product name references in user-visible strings, particularly in "pht()".

Add a linter to identify the use of product name literals in "pht()" text.

The linter could fix these automatically, but it looks like there are fewer than 200 across both Arcanist and Phabricator and some sampling suggests that many are probably clearer when rewritten into generic language anyway.

Test Plan

Ran linter, saw it pop out reasonable warnings.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable