Page MenuHomePhabricator

Add a "product name literal in pht()" linter
ClosedPublic

Authored by epriestley on Apr 25 2022, 4:41 PM.
Tags
None
Referenced Files
F12536920: D21763.diff
Tue, Mar 5, 10:42 AM
Unknown Object (File)
Feb 4 2024, 1:38 AM
Unknown Object (File)
Jan 15 2024, 4:31 AM
Unknown Object (File)
Jan 14 2024, 8:46 AM
Unknown Object (File)
Jan 7 2024, 5:27 AM
Unknown Object (File)
Jan 7 2024, 5:15 AM
Unknown Object (File)
Dec 29 2023, 1:45 PM
Unknown Object (File)
Dec 23 2023, 8:34 AM
Subscribers
None

Details

Summary

Ref T13658. One challenge in forking Phabricator is product name references in user-visible strings, particularly in "pht()".

Add a linter to identify the use of product name literals in "pht()" text.

The linter could fix these automatically, but it looks like there are fewer than 200 across both Arcanist and Phabricator and some sampling suggests that many are probably clearer when rewritten into generic language anyway.

Test Plan

Ran linter, saw it pop out reasonable warnings.

Diff Detail

Repository
rARC Arcanist
Branch
product1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25651
Build 35479: arc lint + arc unit