Page MenuHomePhabricator

Add a "product name literal in pht()" linter
ClosedPublic

Authored by epriestley on Apr 25 2022, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Thu, Jun 16, 10:08 AM
Unknown Object (File)
Mon, Jun 13, 1:30 PM
Unknown Object (File)
Mon, May 30, 4:08 PM
Unknown Object (File)
Mon, May 30, 4:08 PM
Unknown Object (File)
Mon, May 30, 4:08 PM
Unknown Object (File)
Sat, May 28, 12:45 PM
Subscribers
None

Details

Summary

Ref T13658. One challenge in forking Phabricator is product name references in user-visible strings, particularly in "pht()".

Add a linter to identify the use of product name literals in "pht()" text.

The linter could fix these automatically, but it looks like there are fewer than 200 across both Arcanist and Phabricator and some sampling suggests that many are probably clearer when rewritten into generic language anyway.

Test Plan

Ran linter, saw it pop out reasonable warnings.

Diff Detail

Repository
rARC Arcanist
Branch
product1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25651
Build 35479: arc lint + arc unit