Page MenuHomePhabricator

Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator
ClosedPublic

Authored by epriestley on Jul 21 2021, 4:54 PM.
Tags
None
Referenced Files
F13042988: D21703.diff
Wed, Apr 17, 1:58 PM
Unknown Object (File)
Thu, Apr 11, 8:54 AM
Unknown Object (File)
Thu, Apr 11, 6:58 AM
Unknown Object (File)
Fri, Apr 5, 4:31 AM
Unknown Object (File)
Thu, Apr 4, 8:37 AM
Unknown Object (File)
Sat, Mar 30, 4:35 AM
Unknown Object (File)
Mar 13 2024, 11:16 AM
Unknown Object (File)
Feb 4 2024, 1:17 AM
Subscribers
None

Details

Summary

Ref T13660. Clean up callsites to "PhutilExecPassthru->execute()" to prepare to deprecate it.

Test Plan
  • Grepped for "PhutilExecPassthru" and looked for callsites.
  • Ran GIT_SSH=.../ssh-connect git ls-remote origin to execute the "ssh-connect" code.
  • The two passthru future methods have no callers and could possibly be removed, but I'm just letting sleeping dogs lie for now.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable