Paths

Table of Contentst

Differential D21457

Fix additional "xprintf()"-class static parameter lint errors
ClosedPublic
Actions

Authored by epriestley on Sep 8 2020, 3:55 PM.

Details

Reviewers: None
Maniphest Tasks: T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path
Commits: rP6e1b5da1121c: Fix additional "xprintf()"-class static parameter lint errors

Summary

Ref T13577. After the fix in D21453, lint identifies additional static errors in Phabricator; fix them.

Test Plan

Ran arc lint; these messages are essentially all very obscure.

Diff Detail

Repository

rP Phabricator

Branch

linter5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24877
Build 34323: Run Core Tests
Build 34322: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 8 2020, 3:55 PM

Owners added a subscriber: Restricted Owners Package.Sep 8 2020, 3:55 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptSep 8 2020, 3:55 PM

Harbormaster completed remote builds in B24877: Diff 51062.Sep 8 2020, 3:56 PM

epriestley requested review of this revision.Sep 8 2020, 3:56 PM

Herald added a subscriber: hach-que. · View Herald TranscriptSep 8 2020, 3:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 8 2020, 6:45 PM

Closed by commit rP6e1b5da1121c: Fix additional "xprintf()"-class static parameter lint errors (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6e1b5da1121c: Fix additional "xprintf()"-class static parameter lint errors.

epriestley mentioned this in T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.Sep 8 2020, 6:48 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20150602.mlist.2.php

3 lines

src/

applications/

differential/

management/

PhabricatorDifferentialRebuildChangesetsWorkflow.php

3 lines

xaction/

DifferentialRevisionRepositoryTransaction.php

3 lines

fact/

chart/

PhabricatorChartFunctionArgumentParser.php

1 line

harbormaster/

management/

HarbormasterManagementPublishWorkflow.php

1 line

storage/

build/

HarbormasterBuildLog.php

2 lines

maniphest/

constants/

ManiphestTaskPriority.php

3 lines

metamta/

adapter/

PhabricatorMailAdapter.php

1 line

notification/

config/

PhabricatorNotificationServersConfigType.php

4 lines

nuance/

github/

__tests__/

NuanceGitHubRawEventTestCase.php

3 lines

phragment/

controller/

PhragmentRevertController.php

1 line

policy/

storage/

PhabricatorPolicy.php

3 lines

project/

icon/

PhabricatorProjectIconSet.php

1 line

search/

ferret/

function/

FerretSearchFunction.php

4 lines

transactions/

editengine/

PhabricatorEditEngine.php

4 lines

PhabricatorEditEngineSubtype.php

3 lines

infrastructure/

cluster/

PhabricatorDatabaseRefParser.php

2 lines

customfield/

datasource/

PhabricatorCustomFieldApplicationSearchNoneFunctionDatasource.php

2 lines

Diff 51062

View Options

resources/sql/autopatches/20150602.mlist.2.php

View Options

src/applications/differential/management/PhabricatorDifferentialRebuildChangesetsWorkflow.php

View Options

src/applications/differential/xaction/DifferentialRevisionRepositoryTransaction.php

View Options

src/applications/fact/chart/PhabricatorChartFunctionArgumentParser.php

View Options

src/applications/harbormaster/management/HarbormasterManagementPublishWorkflow.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

View Options

src/applications/maniphest/constants/ManiphestTaskPriority.php

View Options

src/applications/metamta/adapter/PhabricatorMailAdapter.php

View Options

src/applications/notification/config/PhabricatorNotificationServersConfigType.php

View Options

src/applications/nuance/github/tests/NuanceGitHubRawEventTestCase.php

View Options

src/applications/phragment/controller/PhragmentRevertController.php

View Options

src/applications/policy/storage/PhabricatorPolicy.php

View Options

src/applications/project/icon/PhabricatorProjectIconSet.php

View Options

src/applications/search/ferret/function/FerretSearchFunction.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php

View Options

src/infrastructure/cluster/PhabricatorDatabaseRefParser.php

View Options

src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchNoneFunctionDatasource.php

Fix additional "xprintf()"-class static parameter lint errorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51062

resources/sql/autopatches/20150602.mlist.2.php

src/applications/differential/management/PhabricatorDifferentialRebuildChangesetsWorkflow.php

src/applications/differential/xaction/DifferentialRevisionRepositoryTransaction.php

src/applications/fact/chart/PhabricatorChartFunctionArgumentParser.php

src/applications/harbormaster/management/HarbormasterManagementPublishWorkflow.php

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

src/applications/maniphest/constants/ManiphestTaskPriority.php

src/applications/metamta/adapter/PhabricatorMailAdapter.php

src/applications/notification/config/PhabricatorNotificationServersConfigType.php

src/applications/nuance/github/__tests__/NuanceGitHubRawEventTestCase.php

src/applications/phragment/controller/PhragmentRevertController.php

src/applications/policy/storage/PhabricatorPolicy.php

src/applications/project/icon/PhabricatorProjectIconSet.php

src/applications/search/ferret/function/FerretSearchFunction.php

src/applications/transactions/editengine/PhabricatorEditEngine.php

src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php

src/infrastructure/cluster/PhabricatorDatabaseRefParser.php

src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchNoneFunctionDatasource.php

Fix additional "xprintf()"-class static parameter lint errors
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/nuance/github/tests/NuanceGitHubRawEventTestCase.php