Page MenuHomePhabricator

Fix an issue where inline comments with only edit suggestions are considered empty
ClosedPublic

Authored by epriestley on May 23 2020, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 29 2022, 5:59 PM
Unknown Object (File)
Dec 25 2022, 11:25 PM
Unknown Object (File)
Dec 17 2022, 10:42 PM
Unknown Object (File)
Nov 23 2022, 12:11 AM
Unknown Object (File)
Nov 23 2022, 12:11 AM
Unknown Object (File)
Nov 23 2022, 12:11 AM
Unknown Object (File)
Nov 15 2022, 7:19 AM
Unknown Object (File)
Nov 15 2022, 7:19 AM
Subscribers

Details

Summary

Ref T13513. An inline is not considered empty if it has a suggestion, but some of the shared transaction code doesn't test for this properly.

Update the shared transaction code to be aware that application comments may have more complex emptiness rules.

Test Plan
  • Posted an inline with only an edit suggestion, comment went through.
  • Tried to post a normal empty comment, got an appropriate warning.

Diff Detail

Repository
rP Phabricator
Branch
empty1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24510
Build 33777: Run Core Tests
Build 33776: arc lint + arc unit

Event Timeline

@epriestley - empty inline comment with suggestion renders rather peculiar transaction which is somewhat confusing and odd... Any plans on tackling it? Like See context greyed out...

image.png (155×1 px, 21 KB)