Page MenuHomePhabricator
Differential D21287

Fix an issue where inline comments with only edit suggestions are considered empty
ClosedPublic
Actions

Authored by epriestley on May 23 2020, 3:18 PM.
Tags
None
Referenced Files
F14077318: D21287.diff
Thu, Nov 21, 10:43 PM
Unknown Object (File)
Sun, Oct 27, 7:25 AM
Unknown Object (File)
Oct 19 2024, 3:28 AM
Unknown Object (File)
Oct 15 2024, 11:25 PM
Unknown Object (File)
Oct 15 2024, 6:13 AM
Unknown Object (File)
Sep 23 2024, 2:12 PM
Unknown Object (File)
Sep 23 2024, 2:07 PM
Unknown Object (File)
Sep 23 2024, 2:07 PM
View All Files
Subscribers
artms
Pawka

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP38991188d6d1: (stable) Fix an issue where inline comments with only edit suggestions are…
rPa529efa5b855: Fix an issue where inline comments with only edit suggestions are considered…
Summary

Ref T13513. An inline is not considered empty if it has a suggestion, but some of the shared transaction code doesn't test for this properly.

Update the shared transaction code to be aware that application comments may have more complex emptiness rules.

Test Plan
  • Posted an inline with only an edit suggestion, comment went through.
  • Tried to post a normal empty comment, got an appropriate warning.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 23 2020, 3:18 PM
Harbormaster completed remote builds in B24510: Diff 50690.May 23 2020, 3:19 PM
epriestley requested review of this revision.May 23 2020, 3:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2020, 3:25 PM
Closed by commit rPa529efa5b855: Fix an issue where inline comments with only edit suggestions are considered… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPa529efa5b855: Fix an issue where inline comments with only edit suggestions are considered….
epriestley added a commit: rP38991188d6d1: (stable) Fix an issue where inline comments with only edit suggestions are….
artms added a subscriber: artms.Oct 22 2020, 9:02 AM

@epriestley - empty inline comment with suggestion renders rather peculiar transaction which is somewhat confusing and odd... Any plans on tackling it? Like See context greyed out...

image.png (155×1 px, 21 KB)

Pawka added a subscriber: Pawka.Oct 22 2020, 9:43 AM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
12 lines
transactions/
storage/
9 lines
12 lines

Diff 50691

View Options

src/applications/differential/storage/DifferentialTransactionComment.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php

Loading...
Phabricator · Built by Phacility