Page MenuHomePhabricator

Make the "attach_inlines" parameter to "differential.createcomment" a no-op
ClosedPublic

Authored by epriestley on May 6 2020, 6:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 1:21 AM
Unknown Object (File)
Fri, Apr 5, 8:51 PM
Unknown Object (File)
Tue, Apr 2, 1:54 AM
Unknown Object (File)
Feb 24 2024, 5:06 PM
Unknown Object (File)
Feb 4 2024, 12:12 AM
Unknown Object (File)
Jan 20 2024, 4:48 PM
Unknown Object (File)
Jan 16 2024, 8:23 PM
Unknown Object (File)
Jan 7 2024, 4:41 PM
Subscribers

Details

Summary

Ref T13513. See that task for some discussion. This prepares to lift "loadUnsubmittedInlineComments(...)" into shared code.

Test Plan

Grepped for callers, found none in the upstream. This is a backward compatibilty break. See T13513.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 10:55 PM
This revision was automatically updated to reflect the committed changes.

What is now programmatical way to "submit" unsubmitted inline comments? Some users are using it to post comments from bots, now if we use differential.createinline api method all bot comments are visible as unsubmitted and looks like there is no way to set it in stone...

I'm not aware of any current customer use cases for this behavior. I'm open to restoring it if customers are actually using it, but would like to make sure the API is fully supporting whatever the need is.

I'm not aware of any current customer use cases for this behavior. I'm open to restoring it if customers are actually using it, but would like to make sure the API is fully supporting whatever the need is.

With newer inline comment functionality there is no ability to create submitted inline comments for bots or via API directly. differential.createinline call might simply always fully publish comments though it will create multiple transactions instead of one which was side effect of old attach_inline functionality. This could as well be differential.editoption to publish inline comments to make it more modern. We use inline comments it for smarter linting messages.

Inline commenting with edit suggestion (I suppose api is not ready for that) can be used to implement linters which offer autoformatting code...

With newer inline comment functionality there is no ability to create submitted inline comments for bots or via API directly.

Correct. I'm not currently aware of any customers who want support for this. If customers request this, I'm happy to revisit support.