Diffusion Phabricator 397648855f8b

Make the "attach_inlines" parameter to "differential.createcomment" a no-op
397648855f8b
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Make the "attach_inlines" parameter to "differential.createcomment" a no-op

Summary: Ref T13513. See that task for some discussion. This prepares to lift "loadUnsubmittedInlineComments(...)" into shared code.

Test Plan: Grepped for callers, found none in the upstream. This is a backward compatibilty break. See T13513.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21225

Details

Provenance

epriestley	Authored on May 6 2020, 6:23 PM
epriestley	Pushed on May 7 2020, 10:55 PM

Differential Revision

D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op

Parents

rP0067f1a521a0: Remove the obsolete "DiffusionInlineCommentPreviewController"

Branches

Unknown

Tags

Unknown

Tasks

T13513: Make schema changes to inlines to prepare for new inline features

Build Status

Buildable 24377
Build 33588: Run Core Tests

Event Timeline

epriestley committed rP397648855f8b: Make the "attach_inlines" parameter to "differential.createcomment" a no-op (authored by epriestley).May 7 2020, 10:55 PM

epriestley added an edge: D21225: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.

epriestley added a task: T13513: Make schema changes to inlines to prepare for new inline features.

Harbormaster completed building B24377: rP397648855f8b: Make the "attach_inlines" parameter to "differential.createcomment" a no-op.May 7 2020, 10:56 PM

Changes (1)

Path

Size

src/

applications/

differential/

conduit/

DifferentialCreateCommentConduitAPIMethod.php

rP397648855f8b

src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php

Loading...