Page MenuHomePhabricator

Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly
ClosedPublic

Authored by epriestley on Nov 25 2019, 11:05 PM.
Tags
None
Referenced Files
F12834665: D20927.diff
Thu, Mar 28, 2:44 PM
Unknown Object (File)
Fri, Mar 15, 5:13 PM
Unknown Object (File)
Feb 20 2024, 10:18 PM
Unknown Object (File)
Feb 3 2024, 11:28 PM
Unknown Object (File)
Jan 7 2024, 4:09 AM
Unknown Object (File)
Jan 4 2024, 5:21 PM
Unknown Object (File)
Dec 31 2023, 7:42 PM
Unknown Object (File)
Dec 27 2023, 8:29 PM
Subscribers
None

Details

Summary

See PHI1558. Ref T11860. Ref T13444. I partly implemented PHIDs for "UserEmail" objects, but they can't load on their own so you can't directly bin/remove destroy them yet.

Allow them to actually load by implementing "PolicyInterface".

Addresses are viewable and editable by the associated user, unless they are a bot/list address, in which case they are viewable and editable by administrators (in preparation for T11860). This has no real impact on anything today.

Test Plan
  • Used bin/remove destroy <phid> to destroy an individual email address.
  • Before: error while loading the object by PHID in the query policy layer.
  • After: clean load and destroy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable