Page MenuHomePhabricator

Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly
ClosedPublic

Authored by epriestley on Nov 25 2019, 11:05 PM.
Tags
None
Referenced Files
F13097922: D20927.id49870.diff
Fri, Apr 26, 3:04 AM
Unknown Object (File)
Thu, Apr 25, 3:34 AM
Unknown Object (File)
Wed, Apr 24, 1:32 PM
Unknown Object (File)
Tue, Apr 16, 4:33 PM
Unknown Object (File)
Thu, Apr 11, 10:49 AM
Unknown Object (File)
Sat, Apr 6, 10:15 PM
Unknown Object (File)
Thu, Mar 28, 2:44 PM
Unknown Object (File)
Mar 15 2024, 5:13 PM
Subscribers
None

Details

Summary

See PHI1558. Ref T11860. Ref T13444. I partly implemented PHIDs for "UserEmail" objects, but they can't load on their own so you can't directly bin/remove destroy them yet.

Allow them to actually load by implementing "PolicyInterface".

Addresses are viewable and editable by the associated user, unless they are a bot/list address, in which case they are viewable and editable by administrators (in preparation for T11860). This has no real impact on anything today.

Test Plan
  • Used bin/remove destroy <phid> to destroy an individual email address.
  • Before: error while loading the object by PHID in the query policy layer.
  • After: clean load and destroy.

Diff Detail

Repository
rP Phabricator
Branch
email1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23699
Build 32583: Run Core Tests
Build 32582: arc lint + arc unit