Page MenuHomePhabricator

Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly
ClosedPublic

Authored by epriestley on Nov 25 2019, 11:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 1:16 AM
Unknown Object (File)
Mon, Dec 30, 1:12 AM
Unknown Object (File)
Sat, Dec 21, 12:08 AM
Unknown Object (File)
Tue, Dec 10, 6:38 PM
Unknown Object (File)
Sat, Dec 7, 6:04 PM
Unknown Object (File)
Dec 3 2024, 3:47 AM
Unknown Object (File)
Nov 27 2024, 10:21 AM
Unknown Object (File)
Nov 16 2024, 6:38 AM
Subscribers
None

Details

Summary

See PHI1558. Ref T11860. Ref T13444. I partly implemented PHIDs for "UserEmail" objects, but they can't load on their own so you can't directly bin/remove destroy them yet.

Allow them to actually load by implementing "PolicyInterface".

Addresses are viewable and editable by the associated user, unless they are a bot/list address, in which case they are viewable and editable by administrators (in preparation for T11860). This has no real impact on anything today.

Test Plan
  • Used bin/remove destroy <phid> to destroy an individual email address.
  • Before: error while loading the object by PHID in the query policy layer.
  • After: clean load and destroy.

Diff Detail

Repository
rP Phabricator
Branch
email1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23699
Build 32583: Run Core Tests
Build 32582: arc lint + arc unit