Page MenuHomePhabricator

Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly

Authored by epriestley on Nov 25 2019, 11:05 PM.



See PHI1558. Ref T11860. Ref T13444. I partly implemented PHIDs for "UserEmail" objects, but they can't load on their own so you can't directly bin/remove destroy them yet.

Allow them to actually load by implementing "PolicyInterface".

Addresses are viewable and editable by the associated user, unless they are a bot/list address, in which case they are viewable and editable by administrators (in preparation for T11860). This has no real impact on anything today.

Test Plan
  • Used bin/remove destroy <phid> to destroy an individual email address.
  • Before: error while loading the object by PHID in the query policy layer.
  • After: clean load and destroy.

Diff Detail

rP Phabricator
Lint OK
Unit Tests OK
Build Status
Buildable 23699
Build 32583: Run Core Tests
Build 32582: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 25 2019, 11:05 PM
epriestley requested review of this revision.Nov 25 2019, 11:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 25 2019, 11:08 PM
This revision was automatically updated to reflect the committed changes.