Differential D20927

Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly
ClosedPublic
Actions

Authored by epriestley on Nov 25 2019, 11:05 PM.

Details

Reviewers: None
Maniphest Tasks: T11860: Bot email addresses can't be edited
T13444: Provide a standalone script entry point for resolving a repository identity
Commits: rP1667acfa5d71: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them…

Summary

See PHI1558. Ref T11860. Ref T13444. I partly implemented PHIDs for "UserEmail" objects, but they can't load on their own so you can't directly bin/remove destroy them yet.

Allow them to actually load by implementing "PolicyInterface".

Addresses are viewable and editable by the associated user, unless they are a bot/list address, in which case they are viewable and editable by administrators (in preparation for T11860). This has no real impact on anything today.

Test Plan

Used bin/remove destroy <phid> to destroy an individual email address.
Before: error while loading the object by PHID in the query policy layer.
After: clean load and destroy.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 25 2019, 11:05 PM

Harbormaster completed remote builds in B23699: Diff 49870.Nov 25 2019, 11:07 PM

epriestley requested review of this revision.Nov 25 2019, 11:07 PM

epriestley mentioned this in T11860: Bot email addresses can't be edited.Nov 25 2019, 11:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 25 2019, 11:08 PM

Closed by commit rP1667acfa5d71: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP1667acfa5d71: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them….

Revision Contents
Changeset List

			Path	Packages
M			src/__phutil_library_map__.php (1 line)
M			src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php (6 lines)
M			src/applications/people/query/PhabricatorPeopleUserEmailQuery.php (26 lines)
M			src/applications/people/storage/PhabricatorUserEmail.php (39 lines)