Differential D20920

When predicting project membership during edits, predict milestones will have parent membership
ClosedPublic
Actions

Authored by epriestley on Nov 19 2019, 6:52 AM.

Tags

None

Referenced Files

	F13078365: D20920.id49847.diff
	Tue, Apr 23, 3:05 PM

	Unknown Object (File)
	Sun, Apr 21, 1:00 PM

	Unknown Object (File)
	Sat, Apr 20, 4:59 PM

	Unknown Object (File)
	Sat, Apr 6, 1:51 AM

	Unknown Object (File)
	Sun, Mar 31, 5:18 PM

	Unknown Object (File)
	Mar 8 2024, 4:13 AM

	Unknown Object (File)
	Feb 23 2024, 4:47 AM

	Unknown Object (File)
	Feb 8 2024, 2:17 AM

View All 70 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13462: Correct some policy/membership issues in milestone creation
Commits: rPd58eddcf0ad4: When predicting project membership during edits, predict milestones will have…

Summary

Depends on D20919. Ref T13462. When editing milestones, we currently predict they will have no members for policy evaluation purposes. This isn't the right rule.

Instead, predict that their membership will be the same as the parent project's membership, and pass this hint to the policy layer.

See T13462 for additional context and discussion.

Test Plan

Set project A's edit policy to "Project Members".
Joined project A.
Tried to create a milestone of project A.
- Before: policy exception that the edit policy excludes me.
- After: clean milestone creation.
As a non-member, tried to create a milestone. Received appropriate policy error.

Diff Detail

Repository

Branch

ppolicy2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23675
Build 32553: Run Core Tests
Build 32552: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 19 2019, 6:52 AM

Harbormaster completed remote builds in B23675: Diff 49847.Nov 19 2019, 6:53 AM

epriestley requested review of this revision.Nov 19 2019, 6:53 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 7:07 AM

Closed by commit rPd58eddcf0ad4: When predicting project membership during edits, predict milestones will have… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd58eddcf0ad4: When predicting project membership during edits, predict milestones will have….

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

73 lines

Diff 49847

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...