Differential D20866

Fix an issue where added or removed source files could incorrectly select a DocumentEngine
ClosedPublic
Actions

Authored by epriestley on Oct 26 2019, 7:09 PM.

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rPf5b3528a2670: (stable) Fix an issue where added or removed source files could incorrectly…
rP292f8fc612bd: Fix an issue where added or removed source files could incorrectly select a…

Summary

Ref T13425. The changes in D20865 could incorrectly lead to selection of a DocumentEngine that can not generate document diffs if a file was added or removed (for example, when a source file is added).

Move the engine pruning code to be shared -- we should always discard engines which can't generate a diff, even if we don't have both documents.

Test Plan

Viewed an added source file, no more document ref error arising from document engine selection.

Diff Detail

Repository

rP Phabricator

Branch

add1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23571
Build 32395: Run Core Tests
Build 32394: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 26 2019, 7:09 PM

Harbormaster completed remote builds in B23571: Diff 49742.Oct 26 2019, 7:11 PM

epriestley requested review of this revision.Oct 26 2019, 7:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 26 2019, 7:16 PM

Closed by commit rP292f8fc612bd: Fix an issue where added or removed source files could incorrectly select a… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP292f8fc612bd: Fix an issue where added or removed source files could incorrectly select a….

epriestley added a commit: rPf5b3528a2670: (stable) Fix an issue where added or removed source files could incorrectly….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

12 lines

Diff 49742

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Fix an issue where added or removed source files could incorrectly select a DocumentEngineClosedPublicActions