Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14104956
D20866.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D20866.diff
View Options
diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php
--- a/src/applications/differential/parser/DifferentialChangesetParser.php
+++ b/src/applications/differential/parser/DifferentialChangesetParser.php
@@ -1743,12 +1743,6 @@
if ($new_engines !== null && $old_engines !== null) {
$shared_engines = array_intersect_key($new_engines, $old_engines);
$default_engine = head_key($new_engines);
-
- foreach ($shared_engines as $key => $shared_engine) {
- if (!$shared_engine->canDiffDocuments($old_ref, $new_ref)) {
- unset($shared_engines[$key]);
- }
- }
} else if ($new_engines !== null) {
$shared_engines = $new_engines;
$default_engine = head_key($shared_engines);
@@ -1759,6 +1753,12 @@
return null;
}
+ foreach ($shared_engines as $key => $shared_engine) {
+ if (!$shared_engine->canDiffDocuments($old_ref, $new_ref)) {
+ unset($shared_engines[$key]);
+ }
+ }
+
$engine_key = $this->getDocumentEngineKey();
if (strlen($engine_key)) {
if (isset($shared_engines[$engine_key])) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Nov 28, 1:09 AM (5 h, 35 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6791895
Default Alt Text
D20866.diff (1 KB)
Attached To
Mode
D20866: Fix an issue where added or removed source files could incorrectly select a DocumentEngine
Attached
Detach File
Event Timeline
Log In to Comment