Page MenuHomePhabricator

Fix an issue where added or removed source files could incorrectly select a DocumentEngine
ClosedPublic

Authored by epriestley on Oct 26 2019, 7:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 3 2024, 11:20 PM
Unknown Object (File)
Jan 31 2024, 6:57 AM
Unknown Object (File)
Dec 26 2023, 1:36 AM
Unknown Object (File)
Dec 24 2023, 3:10 PM
Unknown Object (File)
Dec 13 2023, 8:50 PM
Unknown Object (File)
Nov 30 2023, 2:21 AM
Unknown Object (File)
Nov 25 2023, 10:44 PM
Unknown Object (File)
Nov 16 2023, 12:11 AM
Subscribers
None

Details

Summary

Ref T13425. The changes in D20865 could incorrectly lead to selection of a DocumentEngine that can not generate document diffs if a file was added or removed (for example, when a source file is added).

Move the engine pruning code to be shared -- we should always discard engines which can't generate a diff, even if we don't have both documents.

Test Plan

Viewed an added source file, no more document ref error arising from document engine selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable