Page MenuHomePhabricator

When a task card is edited, emit update events for old boards and parent boards
ClosedPublic

Authored by epriestley on Jul 24 2019, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 1:13 AM
Unknown Object (File)
Fri, Mar 1, 7:34 PM
Unknown Object (File)
Wed, Feb 28, 10:28 PM
Unknown Object (File)
Feb 3 2024, 11:00 PM
Unknown Object (File)
Jan 20 2024, 1:15 AM
Unknown Object (File)
Jan 1 2024, 11:51 PM
Unknown Object (File)
Dec 25 2023, 6:49 AM
Unknown Object (File)
Dec 2 2023, 11:42 PM
Subscribers
None

Details

Summary

Ref T4900. When a card is edited, we currently emit an update notification for all the projects the task is tagged with. This isn't quite the right set:

  • We want to emit notifications for projects the task was previously tagged with, so it can be removed from boards it should no longer be part of.
  • We want to emit notifications for ancestors of projects the task is or was tagged with, so parent project boards can be updated.
  • However, we don't need to emit notifications for projects that don't actually have workboards.

Adjust the notification set to align better to these rules.

Test Plan
  • Removal of Parent Project: Edited a task on board "A > B", removing the "B" project tag. Saw board A update in another window.
  • Normal Update: Edited a task title on board X, saw board X update in another window.
  • Used bin/aphlict debug to inspect the notification set, saw generally sensible-seeming data going over the wire.

Diff Detail

Repository
rP Phabricator
Branch
pnotify1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23190
Build 31852: Run Core Tests
Build 31851: arc lint + arc unit