Page MenuHomePhabricator

Fix some remarkup issues with selective construction of child nodes after HTML DOM parsing
ClosedPublic

Authored by epriestley on Jul 2 2019, 12:04 AM.
Tags
None
Referenced Files
F13050897: D20630.id49226.diff
Fri, Apr 19, 3:16 AM
F13050896: D20630.id49211.diff
Fri, Apr 19, 3:15 AM
F13050895: D20630.id.diff
Fri, Apr 19, 3:15 AM
Unknown Object (File)
Thu, Apr 11, 8:17 AM
Unknown Object (File)
Thu, Apr 11, 4:23 AM
Unknown Object (File)
Wed, Apr 3, 9:18 PM
Unknown Object (File)
Sat, Mar 30, 8:18 AM
Unknown Object (File)
Sat, Mar 30, 8:18 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/bug-in-src-parser-html-phutildomnode-php/2882/.

The behavior of selectChildrenWithTags(...) currently isn't well-covered by tests and isn't quite right. Add coverage and fix it up.

Particularly, there's a bad call to a nonexistent method, and when we convert a tag that doesn't match the selection set into content, we incorrectly discard any paired closing tag.

Test Plan

Added failing tests, made them pass.

Diff Detail

Repository
rPHU libphutil
Branch
html1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23080
Build 31686: Run Core Tests
Build 31685: arc lint + arc unit