Ref T13303. I didn't find any explicit "msortv()" issues in instances/, but did catch one during deploy where we run a ClassMapQuery with a vector-returning sort method.
Test if the sort method returns vectors and "msortv()" it if it does.
Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes
- Commits
- rPHUb675a06bf741: (stable) Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort…
rPHUf5879cc6a9dc: Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
Will cherry-pick and redeploy, just throwing this up for reference/context.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- msortvx
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 23031 Build 31618: Run Core Tests Build 31617: arc lint + arc unit