Page MenuHomePhabricator

Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
ClosedPublic

Authored by epriestley on Jun 22 2019, 4:03 PM.
Tags
None
Referenced Files
F13198996: D20611.diff
Mon, May 13, 10:53 AM
F13187407: D20611.diff
Sat, May 11, 4:30 AM
Unknown Object (File)
Tue, May 7, 7:37 AM
Unknown Object (File)
Fri, May 3, 7:03 AM
Unknown Object (File)
Thu, May 2, 5:30 PM
Unknown Object (File)
Tue, Apr 30, 7:55 PM
Unknown Object (File)
Fri, Apr 26, 2:14 PM
Unknown Object (File)
Thu, Apr 25, 1:24 AM
Subscribers
None

Details

Summary

Ref T13303. I didn't find any explicit "msortv()" issues in instances/, but did catch one during deploy where we run a ClassMapQuery with a vector-returning sort method.

Test if the sort method returns vectors and "msortv()" it if it does.

Test Plan

Will cherry-pick and redeploy, just throwing this up for reference/context.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable