Page MenuHomePhabricator

Fix more "msort()" vs "msortv()" callsites
ClosedPublic

Authored by epriestley on Jun 18 2019, 2:30 PM.
Tags
None
Referenced Files
F15453473: D20587.id.diff
Sat, Mar 29, 12:05 PM
F15451872: D20587.diff
Sat, Mar 29, 12:13 AM
F15444145: D20587.id49108.diff
Thu, Mar 27, 8:05 AM
F15427697: D20587.diff
Sun, Mar 23, 3:40 PM
Unknown Object (File)
Mon, Mar 3, 6:59 PM
Unknown Object (File)
Feb 23 2025, 4:28 AM
Unknown Object (File)
Feb 9 2025, 7:53 AM
Unknown Object (File)
Feb 9 2025, 7:53 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-when-logging-in-with-mfa/2828. The recent changes to turn msort() on a vector an error have smoked out a few more of these mistakes.

These cases do not meaningfully rely on sort stability so there's no real bug being fixed, but we'd still prefer msortv().

Test Plan

Viewed MFA and External Account settings panels. Did a git grep 'msort(' | grep -i vector for any more obvious callsites, but none turned up.

Diff Detail

Repository
rP Phabricator
Branch
sort2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22980
Build 31541: Run Core Tests
Build 31540: arc lint + arc unit