Page MenuHomePhabricator

After reloading transactions for the recipient while building transaction mail, put them in the input order
ClosedPublic

Authored by epriestley on May 30 2019, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 7:22 AM
Unknown Object (File)
Sat, Mar 23, 7:22 AM
Unknown Object (File)
Feb 3 2024, 10:37 PM
Unknown Object (File)
Jan 13 2024, 9:12 AM
Unknown Object (File)
Dec 22 2023, 11:36 PM
Unknown Object (File)
Dec 22 2023, 2:20 AM
Unknown Object (File)
Dec 21 2023, 9:32 PM
Unknown Object (File)
Dec 21 2023, 7:43 PM
Subscribers
None

Details

Summary

Ref T13303. In D20525 I fixed an issue where transaction rendering could use cached values with the wrong viewer by reloading transactions.

However, reloading transactions may also reorder them as a side effect, since withPHIDs(...) does not imply an order. This can make transaction rendering order in mail wrong/inconsistent.

Instead, reorder the transactions before continuing so mail transaction order is consistent.

Test Plan

Applied a group of transactions to a task, saw a more consistent rendering order in mail after the change.

Diff Detail

Repository
rP Phabricator
Branch
sort1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22929
Build 31458: Run Core Tests
Build 31457: arc lint + arc unit