Page MenuHomePhabricator

After reloading transactions for the recipient while building transaction mail, put them in the input order
ClosedPublic

Authored by epriestley on May 30 2019, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 30 2025, 2:24 AM
Unknown Object (File)
May 27 2025, 11:50 AM
Unknown Object (File)
May 26 2025, 11:24 AM
Unknown Object (File)
May 13 2025, 7:46 PM
Unknown Object (File)
May 9 2025, 1:56 PM
Unknown Object (File)
May 9 2025, 1:16 PM
Unknown Object (File)
Apr 28 2025, 4:08 AM
Unknown Object (File)
Apr 25 2025, 11:24 AM
Subscribers
None

Details

Summary

Ref T13303. In D20525 I fixed an issue where transaction rendering could use cached values with the wrong viewer by reloading transactions.

However, reloading transactions may also reorder them as a side effect, since withPHIDs(...) does not imply an order. This can make transaction rendering order in mail wrong/inconsistent.

Instead, reorder the transactions before continuing so mail transaction order is consistent.

Test Plan

Applied a group of transactions to a task, saw a more consistent rendering order in mail after the change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable