Page MenuHomePhabricator

Prevent editing and deleting comments in locked conversations
ClosedPublic

Authored by epriestley on May 23 2019, 6:02 PM.
Tags
None
Referenced Files
F13059228: D20551.diff
Fri, Apr 19, 3:54 PM
F13050868: D20551.diff
Fri, Apr 19, 3:14 AM
Unknown Object (File)
Wed, Apr 3, 5:49 AM
Unknown Object (File)
Tue, Apr 2, 9:01 AM
Unknown Object (File)
Sun, Mar 31, 5:33 AM
Unknown Object (File)
Fri, Mar 29, 8:37 AM
Unknown Object (File)
Sat, Mar 23, 7:20 AM
Unknown Object (File)
Sat, Mar 23, 7:20 AM
Subscribers
None

Details

Summary

Ref T13289. This tightens up a couple of corner cases around locked threads.

Locking is primarily motivated by two use cases: stopping nonproductive conversations on open source installs (similar to GitHub's feature); and freezing object state for audit/record-keeping purposes.

Currently, you can edit or remove comments on a locked thread, but neither use case is well-served by allowing this. Require "CAN_INTERACT" to edit or remove a comment.

Administrators can still remove comments from a locked thread to serve "lock a flamewar, then clean it up", since "Remove Comment" on a comment you don't own is fairly unambiguously an administrative action.

Test Plan
  • On a locked task, tried to edit and remove my comments as a non-administrator. Saw appropriate disabled UI state and error dialogs (actions were disallowed).
  • On a locked task, tried to remove another user's comments as an administrator. This works.
  • On a normal task, edited comments normally.

Diff Detail

Repository
rP Phabricator
Branch
interact1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22900
Build 31414: Run Core Tests
Build 31413: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 23 2019, 8:16 PM