Page MenuHomePhabricator

Prevent editing and deleting comments in locked conversations
ClosedPublic

Authored by epriestley on May 23 2019, 6:02 PM.
Tags
None
Referenced Files
F19056435: D20551.id.diff
Fri, Nov 28, 7:39 PM
F19045424: D20551.diff
Thu, Nov 27, 7:46 AM
F18952349: D20551.diff
Wed, Nov 12, 5:50 AM
F18832159: D20551.id.diff
Oct 25 2025, 7:43 PM
F18827118: D20551.diff
Oct 24 2025, 7:50 AM
F18749144: D20551.id.diff
Oct 4 2025, 2:34 AM
F18681785: D20551.id49026.diff
Sep 26 2025, 4:52 AM
F18625664: D20551.diff
Sep 15 2025, 11:15 PM
Subscribers
None

Details

Summary

Ref T13289. This tightens up a couple of corner cases around locked threads.

Locking is primarily motivated by two use cases: stopping nonproductive conversations on open source installs (similar to GitHub's feature); and freezing object state for audit/record-keeping purposes.

Currently, you can edit or remove comments on a locked thread, but neither use case is well-served by allowing this. Require "CAN_INTERACT" to edit or remove a comment.

Administrators can still remove comments from a locked thread to serve "lock a flamewar, then clean it up", since "Remove Comment" on a comment you don't own is fairly unambiguously an administrative action.

Test Plan
  • On a locked task, tried to edit and remove my comments as a non-administrator. Saw appropriate disabled UI state and error dialogs (actions were disallowed).
  • On a locked task, tried to remove another user's comments as an administrator. This works.
  • On a normal task, edited comments normally.

Diff Detail

Repository
rP Phabricator
Branch
interact1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22900
Build 31414: Run Core Tests
Build 31413: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 23 2019, 8:16 PM