Page MenuHomePhabricator

Prevent editing and deleting comments in locked conversations
ClosedPublic

Authored by epriestley on May 23 2019, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 5, 11:32 PM
Unknown Object (File)
Sun, May 4, 10:59 PM
Unknown Object (File)
Tue, Apr 22, 9:52 AM
Unknown Object (File)
Apr 6 2025, 4:21 PM
Unknown Object (File)
Apr 6 2025, 4:20 PM
Unknown Object (File)
Apr 6 2025, 3:57 PM
Unknown Object (File)
Apr 6 2025, 12:37 AM
Unknown Object (File)
Mar 29 2025, 8:57 AM
Subscribers
None

Details

Summary

Ref T13289. This tightens up a couple of corner cases around locked threads.

Locking is primarily motivated by two use cases: stopping nonproductive conversations on open source installs (similar to GitHub's feature); and freezing object state for audit/record-keeping purposes.

Currently, you can edit or remove comments on a locked thread, but neither use case is well-served by allowing this. Require "CAN_INTERACT" to edit or remove a comment.

Administrators can still remove comments from a locked thread to serve "lock a flamewar, then clean it up", since "Remove Comment" on a comment you don't own is fairly unambiguously an administrative action.

Test Plan
  • On a locked task, tried to edit and remove my comments as a non-administrator. Saw appropriate disabled UI state and error dialogs (actions were disallowed).
  • On a locked task, tried to remove another user's comments as an administrator. This works.
  • On a normal task, edited comments normally.

Diff Detail

Repository
rP Phabricator
Branch
interact1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22900
Build 31414: Run Core Tests
Build 31413: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 23 2019, 8:16 PM