Page MenuHomePhabricator

Label important data on charts
ClosedPublic

Authored by epriestley on May 8 2019, 1:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 7:13 PM
Unknown Object (File)
Tue, Mar 26, 7:13 PM
Unknown Object (File)
Tue, Mar 26, 7:13 PM
Unknown Object (File)
Tue, Mar 26, 7:13 PM
Unknown Object (File)
Sun, Mar 24, 1:39 PM
Unknown Object (File)
Feb 21 2024, 9:32 AM
Unknown Object (File)
Feb 14 2024, 6:46 AM
Unknown Object (File)
Feb 3 2024, 10:25 PM
Subscribers

Details

Summary

Ref T13279. Adds client-side support for rendering function labels on charts, then labels every function as important data.

Works okay on mobile, although I'm not planning to target mobile terribly heavily for v0.

Test Plan

Screen Shot 2019-05-08 at 6.50.04 AM.png (1×1 px, 233 KB)

Diff Detail

Repository
rP Phabricator
Branch
chart23
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22766
Build 31219: Run Core Tests
Build 31218: arc lint + arc unit

Event Timeline

I'm leaning toward putting a fair amount of this rendering in JS since I anticipate a lot of JS nonsense later on (hover/click lines, areas, data points, function labels, etc) and all the SVG rendering is somewhat-necessarily in JS anyway.

This revision is now accepted and ready to land.May 21 2019, 9:36 PM