Page MenuHomePhabricator
Differential D20500

Label important data on charts
ClosedPublic
Actions

Authored by epriestley on May 8 2019, 1:55 PM.
Tags
None
Referenced Files
F18864528: D20500.id.diff
Mon, Nov 3, 5:55 AM
F18851111: D20500.diff
Thu, Oct 30, 10:20 PM
F18832404: D20500.id.diff
Sat, Oct 25, 9:44 PM
F18669759: D20500.diff
Sep 24 2025, 9:48 PM
F18669756: D20500.id.diff
Sep 24 2025, 9:47 PM
F18625087: D20500.id49000.diff
Sep 15 2025, 9:56 PM
F18585795: D20500.id49000.diff
Sep 11 2025, 4:27 PM
F18585769: D20500.id49000.diff
Sep 11 2025, 4:22 PM
View All Files
Subscribers
yelirekim

Details

Reviewers
amckinley
Maniphest Tasks
T13279: Build Charting for Facts
Commits
rPc6052b41a604: Label important data on charts
Summary

Ref T13279. Adds client-side support for rendering function labels on charts, then labels every function as important data.

Works okay on mobile, although I'm not planning to target mobile terribly heavily for v0.

Test Plan

Screen Shot 2019-05-08 at 6.50.04 AM.png (1×1 px, 233 KB)

Diff Detail

Repository
rP Phabricator
Branch
chart23
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22766
Build 31219: Run Core Tests
Build 31218: arc lint + arc unit

Event Timeline

epriestley created this revision.May 8 2019, 1:55 PM
Herald added a subscriber: yelirekim. · View Herald TranscriptMay 8 2019, 1:55 PM
epriestley added a comment.May 8 2019, 1:56 PM

I'm leaning toward putting a fair amount of this rendering in JS since I anticipate a lot of JS nonsense later on (hover/click lines, areas, data points, function labels, etc) and all the SVG rendering is somewhat-necessarily in JS anyway.

Harbormaster completed remote builds in B22766: Diff 48893.May 8 2019, 1:57 PM
epriestley requested review of this revision.May 8 2019, 1:57 PM
amckinley accepted this revision.May 21 2019, 9:36 PM
This revision is now accepted and ready to land.May 21 2019, 9:36 PM
Closed by commit rPc6052b41a604: Label important data on charts (authored by epriestley). · Explain WhyMay 22 2019, 12:21 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc6052b41a604: Label important data on charts.
epriestley mentioned this in rPc6052b41a604: Label important data on charts.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
fact/
engine/
6 lines
webroot/
rsrc/
css/
phui/
41 lines
js/
application/
fact/
79 lines
85 lines

Diff 48893

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/fact/engine/PhabricatorChartRenderingEngine.php

Loading...
View Options

webroot/rsrc/css/phui/phui-chart.css

Loading...
View Options

webroot/rsrc/js/application/fact/Chart.js

Loading...
View Options

webroot/rsrc/js/application/fact/ChartCurtainView.js

Loading...
Phabricator · Built by Phacility