Page MenuHomePhabricator

Remove very old "vsDiff" data from commit update / diff extraction pipeline
ClosedPublic

Authored by epriestley on Apr 11 2019, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 1:54 AM
Unknown Object (File)
Wed, Mar 27, 1:53 AM
Unknown Object (File)
Wed, Mar 27, 1:53 AM
Unknown Object (File)
Tue, Mar 26, 8:26 AM
Unknown Object (File)
Feb 11 2024, 2:55 PM
Unknown Object (File)
Feb 3 2024, 10:04 PM
Unknown Object (File)
Jan 24 2024, 3:50 AM
Unknown Object (File)
Dec 24 2023, 7:02 PM
Subscribers
None

Details

Summary

Ref T13276. This was introduced in D2586 to power a "trigger audits when the committed change does not match the reviewed change" feature. It was removed without ceremony in D15939. Broadly, rebases mean that this sort of feature can't really work like this and this approach is inherently unreliable; see also T182.

This property no longer has readers, and is unlikely to get any in the future since my planned pathway for "committed code must match reviewed code, modulo an automated rebase" is automating the rebase via "Land Revision", not comparing the diff text.

Remove this to simplify the flow of data here so that things in T13276 can be fixed more easily.

Test Plan

Grepped for vsDiff, no hits.

Diff Detail

Repository
rP Phabricator
Branch
update1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22546
Build 30874: Run Core Tests
Build 30873: arc lint + arc unit