Page MenuHomePhabricator
Differential D15939

Update Owners auditing rules for multiple reviewers
ClosedPublic
Actions

Authored by epriestley on May 17 2016, 6:05 PM.
Tags
None
Referenced Files
F13080001: D15939.id38378.diff
Wed, Apr 24, 3:41 AM
F13080000: D15939.id38376.diff
Wed, Apr 24, 3:41 AM
F13079998: D15939.id38375.diff
Wed, Apr 24, 3:41 AM
F13079997: D15939.id.diff
Wed, Apr 24, 3:41 AM
F13079996: D15939.diff
Wed, Apr 24, 3:41 AM
Unknown Object (File)
Fri, Apr 19, 4:42 PM
Unknown Object (File)
Wed, Apr 10, 10:03 AM
Unknown Object (File)
Wed, Apr 10, 2:08 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10181: Create audit requests based on a package commits
T10939: Support for OWNERS files
Commits
rP9c24798e64c9: Update Owners auditing rules for multiple reviewers
Summary

Ref T10939. Fixes T10181. This slightly simplifies, then documents the auditing rules, which haven't been updated for a while. In particular:

  • If an owner authored the change, never audit.
  • Examine all reviewers to determine reviewer audit status, not just the first reviewer.
  • Simplify some of the loading code a bit.
Test Plan
  • Ran bin/repository reparse --owners <commit> --force to trigger this stuff.
  • Verified that the web UI did reasonable things with resulting audits.
  • Read documentation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38375.May 17 2016, 6:05 PM
epriestley retitled this revision from to Update Owners auditing rules for multiple reviewers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10939: Support for OWNERS files, T10181: Create audit requests based on a package commits.
epriestley updated this revision to Diff 38376.May 17 2016, 6:09 PM
  • Wordsmith "were not reviewed by..." to "were not accepted by..." for clarity.
chad accepted this revision.May 17 2016, 6:57 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 17 2016, 6:57 PM
Closed by commit rP9c24798e64c9: Update Owners auditing rules for multiple reviewers (authored by epriestley, committed by epriestley). · Explain WhyMay 17 2016, 8:46 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10939: Support for OWNERS files.May 17 2016, 9:16 PM
epriestley mentioned this in T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.May 23 2016, 7:45 PM
epriestley mentioned this in D20395: Remove very old "vsDiff" data from commit update / diff extraction pipeline.Apr 11 2019, 1:12 PM
epriestley mentioned this in rPd02256df3ca5: Remove very old "vsDiff" data from commit update / diff extraction pipeline.Apr 11 2019, 3:55 PM

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
worker/
168 lines
docs/
user/
userguide/
24 lines

Diff 38378

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php

Loading...
View Options

src/docs/user/userguide/owners.diviner

Loading...
Phabricator · Built by Phacility