Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.
Tags
None
Referenced Files
F18049396: D20387.id.diff
Sun, Aug 3, 4:09 PM
F17866320: D20387.id48654.diff
Jul 28 2025, 4:25 AM
F17866319: D20387.id48650.diff
Jul 28 2025, 4:25 AM
F17866318: D20387.id.diff
Jul 28 2025, 4:25 AM
Unknown Object (File)
May 9 2025, 10:43 AM
Unknown Object (File)
May 9 2025, 12:44 AM
Unknown Object (File)
May 9 2025, 12:44 AM
Unknown Object (File)
May 9 2025, 12:44 AM
Subscribers
None
Tokens
"Love" token, awarded by amckinley.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Screen Shot 2019-04-10 at 9.33.25 AM.png (499×650 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable