Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.
Tags
None
Referenced Files
F19886507: D20387.id.diff
Sun, Mar 22, 5:20 AM
F19859811: D20387.id48654.diff
Sat, Mar 14, 5:37 AM
F19818123: D20387.id48650.diff
Mar 5 2026, 5:53 PM
F19553990: D20387.id48654.diff
Jan 29 2026, 4:33 PM
F19553989: D20387.id48650.diff
Jan 29 2026, 4:33 PM
F19553988: D20387.id.diff
Jan 29 2026, 4:33 PM
F19549704: D20387.id48650.diff
Jan 27 2026, 11:55 AM
F19515222: D20387.diff
Jan 14 2026, 9:24 AM
Subscribers
None
Tokens
"Love" token, awarded by amckinley.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Screen Shot 2019-04-10 at 9.33.25 AM.png (499×650 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable