Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.
Tags
None
Referenced Files
F15489223: D20387.id48654.diff
Fri, Apr 11, 7:07 AM
F15488906: D20387.id48650.diff
Fri, Apr 11, 4:10 AM
F15487276: D20387.id.diff
Thu, Apr 10, 12:50 PM
F15487080: D20387.diff
Thu, Apr 10, 11:02 AM
F15485157: D20387.diff
Wed, Apr 9, 10:12 PM
F15482849: D20387.diff
Wed, Apr 9, 8:26 AM
F15425390: D20387.id48650.diff
Mar 23 2025, 4:31 AM
F15368448: D20387.diff
Mar 12 2025, 2:13 AM
Subscribers
None
Tokens
"Love" token, awarded by amckinley.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Screen Shot 2019-04-10 at 9.33.25 AM.png (499×650 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable