Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.
Tags
None
Referenced Files
F14943979: D20387.id48654.diff
Sat, Feb 15, 6:46 PM
F14943978: D20387.id48650.diff
Sat, Feb 15, 6:46 PM
F14943977: D20387.id.diff
Sat, Feb 15, 6:46 PM
Unknown Object (File)
Fri, Jan 31, 3:36 PM
Unknown Object (File)
Wed, Jan 29, 1:10 AM
Unknown Object (File)
Sun, Jan 26, 11:24 PM
Unknown Object (File)
Sun, Jan 26, 4:54 PM
Unknown Object (File)
Sat, Jan 18, 2:04 AM
Subscribers
None
Tokens
"Love" token, awarded by amckinley.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Screen Shot 2019-04-10 at 9.33.25 AM.png (499×650 px, 162 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable