Page MenuHomePhabricator

Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic

Authored by epriestley on Apr 10 2019, 4:37 PM.

Details

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 10 2019, 4:37 PM
epriestley requested review of this revision.Apr 10 2019, 4:39 PM
amckinley accepted this revision.Apr 10 2019, 5:44 PM

BUT WHY DID YOU CROP THE PICTURE

This revision is now accepted and ready to land.Apr 10 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.