Surface custom form instructions as a "Remarkup" field for the transaction layer
ClosedPublic
Actions

Authored by epriestley on Apr 10 2019, 4:37 PM.

Tags

None

Referenced Files

	F22658981: D20387.id48654.diff
	Thu, Oct 1, 7:17 AM

	F22658980: D20387.id48650.diff
	Thu, Oct 1, 7:17 AM

	F22658978: D20387.id.diff
	Thu, Oct 1, 7:17 AM

	F22656349: D20387.diff
	Thu, Oct 1, 3:55 AM

	F22554684: D20387.diff
	Wed, Sep 23, 11:21 AM

	F22531184: D20387.diff
	Mon, Sep 21, 3:59 PM

	Unknown Object (File)
	Aug 18 2026, 1:33 PM

	Unknown Object (File)
	Jul 8 2026, 9:14 PM

Subscribers

None

Tokens

"Love" token, awarded by amckinley.

Details

Reviewers

amckinley

Maniphest Tasks

T13263: Plans: 2019 Week 11-15 Bonus Content

Commits

Summary

Ref T13263. See https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so {Fxxx} references don't get attached correctly and won't get proper permissions.

Test Plan

Dragged-and-dropped an image into form instructions, saw the file attach to the form: