Page MenuHomePhabricator

Prevent users from removing task titles with "Bulk Edit"
ClosedPublic

Authored by epriestley on Mar 28 2019, 3:57 PM.
Tags
None
Referenced Files
F15197386: D20339.diff
Sat, Feb 22, 11:02 PM
Unknown Object (File)
Fri, Feb 14, 10:47 PM
Unknown Object (File)
Fri, Feb 14, 10:47 PM
Unknown Object (File)
Fri, Feb 14, 10:47 PM
Unknown Object (File)
Fri, Feb 14, 10:47 PM
Unknown Object (File)
Tue, Feb 4, 10:55 PM
Unknown Object (File)
Tue, Feb 4, 4:44 AM
Unknown Object (File)
Tue, Jan 28, 11:34 PM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T209449.

The "Bulk Edit" flow works with setContinueOnMissingFields(true), so newRequiredError() errors are ignored. This allows you to apply a transaction which changes the title to "" (the empty string) without actually hitting any errors which the workflow respects.

(Normally, setContinueOnMissingFields(...) workflows only edit properties that can't be missing, like the status of an object, so this is an unusual flow.)

Instead, validate more narrowly:

  • Transactions which would remove the title get an "invalid" error, which is respected even under "setContinueOnMissingFields()".
  • Then, we try to raise a "missing/required" error if everything otherwise looks okay.
Test Plan
  • Edited a task title normally.
  • Edited a task to remove the title (got an error).
  • Created a task with no title (disallowed: got an error).
  • Bulk edited a task to remove its title.
    • Before change: allowed.
    • After change: disallowed.

Diff Detail

Repository
rP Phabricator
Branch
task1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22415
Build 30670: Run Core Tests
Build 30669: arc lint + arc unit