Page MenuHomePhabricator

Prevent users from removing task titles with "Bulk Edit"
ClosedPublic

Authored by epriestley on Mar 28 2019, 3:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 3:44 PM
Unknown Object (File)
Wed, Apr 3, 9:43 PM
Unknown Object (File)
Wed, Apr 3, 1:04 PM
Unknown Object (File)
Mon, Apr 1, 6:46 AM
Unknown Object (File)
Mar 25 2024, 7:41 AM
Unknown Object (File)
Mar 25 2024, 7:40 AM
Unknown Object (File)
Mar 25 2024, 7:40 AM
Unknown Object (File)
Mar 25 2024, 7:40 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T209449.

The "Bulk Edit" flow works with setContinueOnMissingFields(true), so newRequiredError() errors are ignored. This allows you to apply a transaction which changes the title to "" (the empty string) without actually hitting any errors which the workflow respects.

(Normally, setContinueOnMissingFields(...) workflows only edit properties that can't be missing, like the status of an object, so this is an unusual flow.)

Instead, validate more narrowly:

  • Transactions which would remove the title get an "invalid" error, which is respected even under "setContinueOnMissingFields()".
  • Then, we try to raise a "missing/required" error if everything otherwise looks okay.
Test Plan
  • Edited a task title normally.
  • Edited a task to remove the title (got an error).
  • Created a task with no title (disallowed: got an error).
  • Bulk edited a task to remove its title.
    • Before change: allowed.
    • After change: disallowed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable