D20339.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D20339.diff
View Options

	diff --git a/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php b/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php
	--- a/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php
	+++ b/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php
	@@ -64,9 +64,27 @@
	public function validateTransactions($object, array $xactions) {
	$errors = array();

	- if ($this->isEmptyTextTransaction($object->getTitle(), $xactions)) {
	- $errors[] = $this->newRequiredError(
	- pht('Tasks must have a title.'));
	+ // If the user is acting via "Bulk Edit" or another workflow which
	+ // continues on missing fields, they may be applying a transaction which
	+ // removes the task title. Mark these transactions as invalid first,
	+ // then flag the missing field error if we don't find any more specific
	+ // problems.
	+
	+ foreach ($xactions as $xaction) {
	+ $new = $xaction->getNewValue();
	+ if (!strlen($new)) {
	+ $errors[] = $this->newInvalidError(
	+ pht('Tasks must have a title.'),
	+ $xaction);
	+ continue;
	+ }
	+ }
	+
	+ if (!$errors) {
	+ if ($this->isEmptyTextTransaction($object->getTitle(), $xactions)) {
	+ $errors[] = $this->newRequiredError(
	+ pht('Tasks must have a title.'));
	+ }
	}

	return $errors;