Page MenuHomePhabricator

Make the new Build Plan behavior "Restartable" work
ClosedPublic

Authored by epriestley on Feb 28 2019, 8:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 5:27 AM
Unknown Object (File)
Wed, Apr 3, 12:04 PM
Unknown Object (File)
Wed, Apr 3, 12:03 PM
Unknown Object (File)
Wed, Apr 3, 12:03 PM
Unknown Object (File)
Mar 18 2024, 3:04 AM
Unknown Object (File)
Feb 19 2024, 7:43 PM
Unknown Object (File)
Feb 16 2024, 10:37 PM
Unknown Object (File)
Jan 17 2024, 8:41 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. Implements the "Restartable" behavior, to control whether a build may be restarted or not.

This is fairly straightforward because there are already other existing reasons that a build may not be able to be restarted.

Test Plan

Restarted a build. Marked it as not restartable, saw "Restart" action become disabled. Tried to restart it anyway, got a useful error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 8:05 PM

Does anyone want an option for "only allow builds that have failed to be restarted"? For cases where builds are idempotent except for a final irrevocable step like "find servers running any version of the code != this version and kill them"?

This revision is now accepted and ready to land.Mar 5 2019, 7:47 PM

I haven't seen any of that so far, but it seems pretty reasonable to me. Maybe I'll just add it unless I can come up with some reason why it's secretly bad in the time it takes to implement.

This revision was automatically updated to reflect the committed changes.