Page MenuHomePhabricator

Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
ClosedPublic

Authored by epriestley on Feb 12 2019, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 14, 4:25 PM
Unknown Object (File)
Sat, Jun 11, 2:53 PM
Unknown Object (File)
May 29 2022, 12:33 AM
Subscribers

Details

Summary

Ref T13250. See D20149. Mostly: clarify semantics. Partly: remove magic "null" behavior.

Test Plan

Poked around, but mostly just inspection since these are pretty much one-for-one.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2019, 9:39 PM
Harbormaster failed remote builds in B21964: Diff 48120!

Depends on D20149. In the cases where the second parameter is a variable, there's some possibility that it's sometimes null in some tricky case, although I've tried to look through all the callsites and catch any of this. If this is the case, we'll get an explicit exception shortly ("second parameter to replace must not be null").

This revision is now accepted and ready to land.Feb 14 2019, 7:42 PM
This revision was automatically updated to reflect the committed changes.