Page MenuHomePhabricator
Differential D20150

Replace "getRequestURI()->setQueryParams(array())" with "getPath()"
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 4:09 PM.
Tags
None
Referenced Files
F14317089: D20150.diff
Wed, Dec 18, 7:48 AM
F14291085: D20150.diff
Tue, Dec 17, 9:15 AM
Unknown Object (File)
Mon, Dec 9, 7:57 AM
Unknown Object (File)
Thu, Dec 5, 12:44 AM
Unknown Object (File)
Tue, Dec 3, 10:41 AM
Unknown Object (File)
Sun, Dec 1, 1:06 PM
Unknown Object (File)
Tue, Nov 26, 10:30 PM
Unknown Object (File)
Sat, Nov 23, 1:12 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules
Commits
rPfcd85b6d7bed: Replace "getRequestURI()->setQueryParams(array())" with "getPath()"
Summary

Ref T13250. A handful of callsites are doing getRequestURI() + setQueryParams(array()) to get a bare request path.

They can just use getPath() instead.

Test Plan

See inlines.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2019, 4:09 PM
Harbormaster completed remote builds in B21954: Diff 48111.Feb 12 2019, 4:11 PM
epriestley requested review of this revision.Feb 12 2019, 4:11 PM
epriestley added inline comments.Feb 12 2019, 4:12 PM
src/aphront/response/AphrontAjaxResponse.php
34–51

Test plan: viewed a revision in Differential, opened DarkConsole, saw the Ajax "request" tabs populate on the left.

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
14

Test plan: viewed /chatlog/channel/1/, which hits this code before 404'ing.

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
57

Test plan: added and removed application email addresses for Maniphest.

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
34

Test plan: added and removed account email addresses.

src/applications/transactions/editengine/PhabricatorEditEngine.php
1282

Test plan: edited a task.

amckinley accepted this revision.Feb 12 2019, 7:29 PM
This revision is now accepted and ready to land.Feb 12 2019, 7:29 PM
Closed by commit rPfcd85b6d7bed: Replace "getRequestURI()->setQueryParams(array())" with "getPath()" (authored by epriestley). · Explain WhyFeb 12 2019, 10:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
response/
12 lines
applications/
chatlog/
controller/
3 lines
metamta/
applicationpanel/
3 lines
settings/
panel/
3 lines
transactions/
editengine/
3 lines

Diff 48125

View Options

src/aphront/response/AphrontAjaxResponse.php

Loading...
View Options

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

Loading...
View Options

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
Phabricator · Built by Phacility