Page MenuHomePhabricator
Differential D20150

Replace "getRequestURI()->setQueryParams(array())" with "getPath()"
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 4:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:39 PM
Unknown Object (File)
Tue, Apr 23, 6:32 PM
Unknown Object (File)
Tue, Apr 16, 4:56 AM
Unknown Object (File)
Thu, Apr 11, 7:36 AM
Unknown Object (File)
Sat, Apr 6, 3:11 PM
Unknown Object (File)
Wed, Apr 3, 12:00 PM
Unknown Object (File)
Tue, Apr 2, 3:21 AM
Unknown Object (File)
Mar 15 2024, 11:16 AM
View All 97 Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules
Commits
rPfcd85b6d7bed: Replace "getRequestURI()->setQueryParams(array())" with "getPath()"
Summary

Ref T13250. A handful of callsites are doing getRequestURI() + setQueryParams(array()) to get a bare request path.

They can just use getPath() instead.

Test Plan

See inlines.

Diff Detail

Repository
rP Phabricator
Branch
uri2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21954
Build 29979: Run Core Tests
Build 29978: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2019, 4:09 PM
Harbormaster completed remote builds in B21954: Diff 48111.Feb 12 2019, 4:11 PM
epriestley requested review of this revision.Feb 12 2019, 4:11 PM
epriestley added inline comments.Feb 12 2019, 4:12 PM
src/aphront/response/AphrontAjaxResponse.php
34–51

Test plan: viewed a revision in Differential, opened DarkConsole, saw the Ajax "request" tabs populate on the left.

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
14

Test plan: viewed /chatlog/channel/1/, which hits this code before 404'ing.

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
57

Test plan: added and removed application email addresses for Maniphest.

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
34

Test plan: added and removed account email addresses.

src/applications/transactions/editengine/PhabricatorEditEngine.php
1282

Test plan: edited a task.

amckinley accepted this revision.Feb 12 2019, 7:29 PM
This revision is now accepted and ready to land.Feb 12 2019, 7:29 PM
Closed by commit rPfcd85b6d7bed: Replace "getRequestURI()->setQueryParams(array())" with "getPath()" (authored by epriestley). · Explain WhyFeb 12 2019, 10:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
response/
12 lines
applications/
chatlog/
controller/
3 lines
metamta/
applicationpanel/
3 lines
settings/
panel/
3 lines
transactions/
editengine/
3 lines

Diff 48111

View Options

src/aphront/response/AphrontAjaxResponse.php

Loading...
View Options

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

Loading...
View Options

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
Phabricator · Built by Phacility