Diffusion Phabricator 00ffb190cc71

In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"
00ffb190cc71
Actions

Tags

None

Referenced Files

	F6206016: Screen Shot 2019-02-12 at 5.49.06 AM.png
	Feb 12 2019, 10:41 PM

Subscribers

None

Description

In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"

Summary: See PHI1068. We currently show "HTTP Error - 200", which is misleading. Instead, label these results as "HTTP Status Code".

Test Plan:

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20148

Details

Provenance

epriestley	Authored on Feb 12 2019, 1:49 PM
epriestley	Pushed on Feb 12 2019, 10:41 PM

Reviewer

Differential Revision

D20148: In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"

Parents

rP308c4f240754: Fix "AphrontRequest->getRequestURI()" for requests with "x[]=1" parameters in…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 21968
Build 30004: Run Core Tests

Event Timeline

epriestley committed rP00ffb190cc71: In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error" (authored by epriestley).Feb 12 2019, 10:41 PM

Harbormaster completed building B21968: rP00ffb190cc71: In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error".Feb 12 2019, 10:42 PM

Changes (1)

Path

Size

src/

applications/

herald/

storage/

HeraldWebhookRequest.php

rP00ffb190cc71

src/applications/herald/storage/HeraldWebhookRequest.php

Loading...