Page MenuHomePhabricator

Replace "getRequestURI()->setQueryParams(array())" with "getPath()"
ClosedPublic

Authored by epriestley on Feb 12 2019, 4:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 4, 2:23 AM
Unknown Object (File)
Sat, Jul 2, 10:29 PM
Unknown Object (File)
Tue, Jun 28, 9:42 AM
Unknown Object (File)
Sun, Jun 26, 3:58 PM
Unknown Object (File)
Wed, Jun 15, 5:32 PM
Unknown Object (File)
Wed, Jun 15, 2:41 AM
Unknown Object (File)
Sat, Jun 11, 7:07 PM
Unknown Object (File)
Thu, Jun 9, 5:56 PM
Subscribers
None

Details

Summary

Ref T13250. A handful of callsites are doing getRequestURI() + setQueryParams(array()) to get a bare request path.

They can just use getPath() instead.

Test Plan

See inlines.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/aphront/response/AphrontAjaxResponse.php
34–51

Test plan: viewed a revision in Differential, opened DarkConsole, saw the Ajax "request" tabs populate on the left.

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
14

Test plan: viewed /chatlog/channel/1/, which hits this code before 404'ing.

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
57

Test plan: added and removed application email addresses for Maniphest.

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
34

Test plan: added and removed account email addresses.

src/applications/transactions/editengine/PhabricatorEditEngine.php
1282

Test plan: edited a task.

This revision is now accepted and ready to land.Feb 12 2019, 7:29 PM
This revision was automatically updated to reflect the committed changes.