Paths

Table of Contentst

Differential D20150

Replace "getRequestURI()->setQueryParams(array())" with "getPath()"
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 4:09 PM.

Tags

None

Referenced Files

	F19097377: D20150.id.diff
	Dec 4 2025, 1:16 PM

	F18849959: D20150.id.diff
	Oct 30 2025, 1:29 PM

	F18831957: D20150.id.diff
	Oct 25 2025, 5:42 PM

	F18773660: D20150.diff
	Oct 9 2025, 11:40 AM

	F18751112: D20150.diff
	Oct 4 2025, 9:47 AM

	F18748806: D20150.id.diff
	Oct 4 2025, 12:52 AM

	F18718230: D20150.id48125.diff
	Sep 29 2025, 3:22 PM

	F18686654: D20150.id.diff
	Sep 26 2025, 1:15 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules

Commits

rPfcd85b6d7bed: Replace "getRequestURI()->setQueryParams(array())" with "getPath()"

Summary

Ref T13250. A handful of callsites are doing getRequestURI() + setQueryParams(array()) to get a bare request path.

They can just use getPath() instead.

Test Plan

See inlines.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2019, 4:09 PM

Harbormaster completed remote builds in B21954: Diff 48111.Feb 12 2019, 4:11 PM

epriestley requested review of this revision.Feb 12 2019, 4:11 PM

epriestley added inline comments.Feb 12 2019, 4:12 PM

src/aphront/response/AphrontAjaxResponse.php
34–51	Test plan: viewed a revision in Differential, opened DarkConsole, saw the Ajax "request" tabs populate on the left.
src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
14	Test plan: viewed `/chatlog/channel/1/`, which hits this code before 404'ing.
src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
57	Test plan: added and removed application email addresses for Maniphest.
src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
34	Test plan: added and removed account email addresses.
src/applications/transactions/editengine/PhabricatorEditEngine.php
1282	Test plan: edited a task.

amckinley accepted this revision.Feb 12 2019, 7:29 PM

This revision is now accepted and ready to land.Feb 12 2019, 7:29 PM

Closed by commit rPfcd85b6d7bed: Replace "getRequestURI()->setQueryParams(array())" with "getPath()" (authored by epriestley). · Explain WhyFeb 12 2019, 10:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

response/

AphrontAjaxResponse.php

12 lines

applications/

chatlog/

controller/

PhabricatorChatLogChannelLogController.php

3 lines

metamta/

applicationpanel/

PhabricatorMetaMTAApplicationEmailPanel.php

3 lines

settings/

panel/

PhabricatorEmailAddressesSettingsPanel.php

3 lines

transactions/

editengine/

PhabricatorEditEngine.php

3 lines

Diff 48125

src/aphront/response/AphrontAjaxResponse.php

Loading...

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

Loading...

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php

Loading...

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...